AnubisNekhet / AnuPpuccin

Personal theme for Obsidian
GNU General Public License v3.0
2.22k stars 163 forks source link

[Feature Request] Style Settings option: code blocks -> code text color #31

Closed Criamos closed 1 year ago

Criamos commented 1 year ago

Feature Description A color setting similar to the "Minimal"-theme (with Style Settings plugin) that enables the user to change the

Miscellaneous Features

Additional context For reference - the aforementioned feature in the "Minimal"-theme Style Settings (see: Style Settings -> Minimal -> Code blocks) looks like this: Obsidian_ClS9Ar5447

I've used this feature to give my single-line code blocks (the single backtick code blocks don't get syntax-highlighted most of the time) a slightly more colorful hue to make them stand out a little bit more from normal text.


P.S.: You've developed a lovely theme! I especially like the extended color-schemes in combination with the "simple" rainbow folder colors. Makes it really easy to keep track of in which folder structure I'm currently in. Thank you for taking the time out of your day and sharing your work with the Obsidian community! ๐Ÿ’Ÿ

AnubisNekhet commented 1 year ago

I've added an option to set custom colors for both, and it should be available with the next release. Hope that helps! ๐Ÿ˜Š

AnubisNekhet commented 1 year ago

Added with v1.2.8 :)

Criamos commented 1 year ago

Thank you a lot! :)

An observation I just made while testing out code text colors: It works great in Obsidian's "reading"-mode, but doesn't reliably recolor text in live-preview nor source-viewing-mode. The only elements where code text gets the overwritten color in live-preview mode is transclusions and callouts. If you use a code block within a normal sentence, like this, it stays at the default color.

AllanFerencz commented 1 year ago

Related is the PDF export for code. Inline it's hard to read and the background field doesn't seem to change the color it exports.

Example image

Zabooby commented 1 year ago

I can't seem to find the option to change the colour of highlights.

AnubisNekhet commented 1 year ago

I can't seem to find the option to change the colour of highlights.

I don't plan to support changing highlight colors right now since they add quite a lot of classes to the mix and it can get quite messy, sorry if that's an inconvenience ๐Ÿ˜…

Zabooby commented 1 year ago

I can't seem to find the option to change the colour of highlights.

I don't plan to support changing highlight colors right now since they add quite a lot of classes to the mix and it can get quite messy, sorry if that's an inconvenience ๐Ÿ˜…

No problem, it's not a deal-breaker for me.