environment sprites not rendered correctly when overriden with a texture pack

hortiSquash commented 2 months ago

Platforms

Windows

Build

25254

Issue

the game doesnt pack correctly the atlas when using a texture pack that overrides the environment textures every time you disable and re-enable the mod, a different result happens (see images)

please note that this only happens when the textures are above a certain size

the larger the textures, the more intense are the bugs (at 2x the game resolution, it looks like everything works perfectly, but more and things start to break) since some sprites are still drawn correctly, this is not a rendering issue, i believe this is due to the Atlas?

i also think this might be related to the amount of large sprites in the mod, maybe with just a few sprites you wouldnt run into the bug (hypothesis, i didnt test that)

Steps to reproduce

just install the mod i linked and load any map (one that has multiple floor textures would obviously be better)

Mods used

hortiDefinition_x4.zip

Save file

No response

(Crash) logs

no crash, it runs perfectly

Submission

[X] I have updated to the latest release (https://github.com/Anuken/Mindustry/releases) to make sure my issue has not been fixed.
[X] I have searched the closed and open issues to make sure that this problem has not already been reported.
[X] I am not using Foo's Client, and have made sure the bug is not caused by mods I have installed.

mahdoosh1 commented 1 month ago

i love glitches

hortiSquash commented 1 month ago

@Anuken the same issue is still present if i increase the environment resolution very slightly more than the test mod i provided

i dont understand why is that, because the blocks and units textures work perfectly, only the environment are bugged like this well anyway, thanks for fixing the 4x 🥳

Anuken commented 1 month ago

All environment regions must be on the same texture for technical reasons. 4k is the maximum safe size. I will not be increasing it further.

Anuken / Mindustry