search

AnupK1234 / MealMatters

MealMatters is a webapp designed to overcome student food insecurity by connecting students with nearby restaurants that provide free meals.
https://meal-matters-client.vercel.app/
MIT License
1 stars 2 forks source link

enhancement : Global Exception Handling #35

Closed Kombaiya-MK closed 8 months ago

Kombaiya-MK commented 9 months ago

Issue Template

Please fill out this template to help us troubleshoot your issue as quickly as possible.

Issue type

Description

Enhancing the exception handling by adding global exceptions.

Steps to reproduce

  1. To Add global exception handlers in the app.js

Expected behavior

Kombaiya-MK commented 9 months ago

I am excited to work on this @AnupK1234 can you assign me this for SWOC24

AnupK1234 commented 9 months ago

Kindly elaborate more what enhancement you would like to make

Jainil2004 commented 8 months ago

hi @Kombaiya-MK I would like to contribute to this project. So can I please work on this issue under SWOC24. I am a SWOC24 contributor. thank you

Jainil2004 commented 8 months ago

currently one potential issue where we can add exception handling is to catch unhandled exceptions that may arise during the request-response cycle. which I would be solving by adding a generic middleware exception handler such that it will catch everything exception thrown at it.

AnupK1234 commented 8 months ago

@Jainil2004 Are you done working on this issue?

Jainil2004 commented 8 months ago

Yep I am almost done. Will generate a PR by the end of the day.

Jainil2004 commented 8 months ago

@AnupK1234 I have successfully resolved the issue and have submitted a PR for the same. Please review it and do let me know if something needs to be fixed. thank you