search

Anupam-dagar / Portfolio-Generator

HoxNox - Portfolios Made Easy, Generate portfolios in 3 easy steps
https://hoxnox.herokuapp.com/
MIT License
175 stars 82 forks source link

new homepage template added #39

Closed rudransh1 closed 6 years ago

rudransh1 commented 6 years ago

issue #28 resolved

gauthamzz commented 6 years ago

how many files are you adding, 😄 dont you think its bigger than the size of the project and its a bit too much.

mubaris commented 6 years ago

Codacy is saying that you're adding "110 extra issues" 😄

rudransh1 commented 6 years ago

I just created a new homepage as asked by @Anupam-dagar.

Anupam-dagar commented 6 years ago

that's right, codacy checks if not passed should atleast produce less issues. Coming to file changed "125", I can't merge it with that many changes, keep only neccessary files i.e html of homepage,css,js and required images, anything not in use should not be present. @hacker1x1x1 it's not only about resolving the issue, you need to take care about other factors too, code quality, directory structure, unused files.

gauthamzz commented 6 years ago

well you need to solve the codacy issues 😄 and 110 doesnt look that good.

@Anupam-dagar i thought you didnt like codacy 😄

rudransh1 commented 6 years ago

I just added the whole content present inside the template folder I downloaded What should I do now @Anupam-dagar @gauthamzz ?

Anupam-dagar commented 6 years ago

hahahaa, only first encounter was bad :stuck_out_tongue: @gauthamzz

rudransh1 commented 6 years ago

it has passes all the tests @Anupam-dagar