search

Anupya / JapaneseTab

A Chrome extension that helps you learn Japanese with every new tab :red_circle:
https://chrome.google.com/webstore/detail/japanesetab/jndamehabjcbgopalgabjpplldmjnnfn?hl=en-GB&gl=CA
MIT License
66 stars 8 forks source link

Implemented options for turning off romaji and switching hiragana/kanji #6

Closed clausagerskov closed 5 years ago

clausagerskov commented 5 years ago

There seems to be a divide among the users regarding the kanji/hiragana positions. Some want kanji on top (myself included) and some want hiragana on top. Also there was an issue where somebody wanted the option to turn off romaji (as romaji is not going to help people really get good at Japanese). I have implemented the option to turn on/off romaji, as well as switch kanji/hiragana positions, so all the people will be happy. The implementation includes a settings button to open the options window so people can set-up the extension to their liking.

clausagerskov commented 5 years ago

any comment on whether or not this will be merged?

Anupya commented 5 years ago

Hey there! I took a look at your code and everything works as expected. I'm going to fix the UI of the Options page after merging it though. Thanks for the PR!