search

AnuragThePathak / News-Feed-App

Get news from the world.
Apache License 2.0
4 stars 9 forks source link

added <times ago> to the news template #11

Closed gururani-abhishek closed 3 years ago

gururani-abhishek commented 3 years ago 
shows hours if the time between published time and current time is less than 24 otherwise shows difference of days.
gururani-abhishek commented 3 years ago

@AnuragThePathak I got you, also this is my 3rd PR on GitHub. Now after making changes to my code base do I need to close this PR and then make a fresh one again?

AnuragThePathak commented 3 years ago

No you simply push the commit to the same and then you'll be able to update PR ig. No need to close.

gururani-abhishek commented 3 years ago

I was figuring out stuff and did something weird, anyway made the changes that you've suggested :)

gururani-abhishek commented 3 years ago

Can you show me some examples? As Repository is not the part of MVVM architecture I have no idea what norms are followed there.

AnuragThePathak commented 3 years ago

Unfortunately I am also having this situation for the first time hence no example. It's just my attempt to write modular code. Anyway I am doing it myself.