search

AnuragThePathak / News-Feed-App

Get news from the world.
Apache License 2.0
4 stars 9 forks source link

Add a bottom bar having three destination. #27

Closed AnuragThePathak closed 3 years ago

AnuragThePathak commented 3 years ago

The destinations should be-

  1. Home - It should contain all the screens we have right now i.e. home, settings, notification.
  2. Explore- Just make a dummy screen for now.
  3. Library- Dummy screen.
droid-it commented 3 years ago

Can I pick this up?

AnuragThePathak commented 3 years ago

Yes sure. Btw I would like to inform that your github account is not being shown in your last contributions. You fix that this time (if interested).

droid-it commented 3 years ago

Could you please explain what do you mean by github account not showing?

AnuragThePathak commented 3 years ago

For example your name is not shown in list of contributors of this repository.

AnuragThePathak commented 3 years ago

Also see commit history of this file. You'll see your account but not the github one. Maybe your git is configured with an email different than your github account. As a matter of fact I am even unable to tag you here.

droid-it commented 3 years ago

Oh, I am not sure what can I do about that. In any case, please assign this issue to me

AnuragThePathak commented 3 years ago

Oh, I am not sure what can I do about that. In any case, please assign this issue to me

I have checked git log and found your email configured in your git account as you@gmail.com

You may configure it using

git config --global user.email "$your_email" Replace $your_email with your email.

droid-it commented 3 years ago

Thanks for the tip! I've raised the fix for this here https://github.com/AnuragThePathak/News-Feed-App/pull/28

AnuragThePathak commented 3 years ago

@droid-it You make a slight change do not show the back arrow anywhere. Moreover it's not working even as they explore and library are separate tasks.