Closed joshniemela closed 8 months ago
@joshniemela, thanks for scaffolding this.
Some notes:
The version is bumped by the release action automatically. So 3a4e40c38ed381f5b8cd1eb048319ccc21ea4930 isn't necessary.
Could you please run
cargo fmt
cargo clippy --fix
Also, please pull the latest changes from the upstream. 5bfd2de6d2139d074a18d084c8655c4ad78a7ea4, for the tests to pass.
Removed version bump and fixed the two linting errors, sorry for taking so long I had some exams to do.
Thanks for this @joshniemela. I am thinking of adding https://codspeed.io/ on top of this. As it goes well with Criterion.
:tada: This PR is included in version 2.1.0 :tada:
The release is available on:
v2.1.0
Your semantic-release bot :package::rocket:
There is a lot of parallelisation in the embedding functions which I suspect some of them may just be adding additional overhead, this benchmark should serve as a first step to optimising the performance further.