Anush008 / fastembed-rs

Library for generating vector embeddings, reranking in Rust
https://docs.rs/fastembed
Apache License 2.0
264 stars 36 forks source link

[issue] Fastembed build is failing #43

Closed jay11ca39 closed 6 months ago

jay11ca39 commented 6 months ago

I have created a sample cargo project: $ cargo init

Added Fastembed dependency in cargo.toml file .. [dependencies] fastembed = "3"

$ cargo build

It is failing ..

As per the analysis it is due to yesterday's release of ort.. in which apis got changed..

Anush008 commented 6 months ago

You're right. I'll add fix.

jay11ca39 commented 6 months ago

Shouldn't be the case. Since the ort version is pinned in FastEmbed and we have not bumped it.

Thanks @Anush008 for reply. But I was able to build it earlier.. there is no changes in my side. Creating a sample project also not building . Did you build it today or can you just try to create a sample cargo project and add fastembed dependency.. ?

Anush008 commented 6 months ago

Yes. My bad. I reran the CI of #40. It failed.

github-actions[bot] commented 6 months ago

:tada: This issue has been resolved in version 3.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Anush008 commented 6 months ago

Thanks for reporting Jay.

jay11ca39 commented 6 months ago

Thanks for reporting Jay.

You are welcome..

Yes. My bad. I reran the CI of #40. It failed.

I am able to build with fix which is merged #44

Anush008 commented 6 months ago

FastEmbed v3.3.0 should work fine.

Anush008 commented 6 months ago

Why this happened?

We mentioned the version as ort = { version = "2.0.0-rc.0"} which is not really strict pinning.

Since this string does not have any operators in it, it is interpreted the same way as if we had specified "^0.1.12", which is called a caret requirement.

Caret requirements allow SemVer compatible updates to a specified version. An update is allowed if the new version number does not modify the left-most non-zero digit in the major, minor, patch grouping.

Strict pinning is ort = { version = "=2.0.0-rc.0"}