Anushkabh / krishiconnect

https://krishiconnect-mu.vercel.app/
MIT License
65 stars 152 forks source link

Replaced Rp with ₹ #650

Closed Saipradyumnagoud closed 1 day ago

Saipradyumnagoud commented 1 week ago

Replaced rp with ₹ because ecommerce websites dont have rp they have ₹ only . closes #634

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
krishiconnect ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 0:08am
Saipradyumnagoud commented 1 week ago

@Anushkabh please review the pull request

himanshu-03 commented 1 day ago

@Saipradyumnagoud you were not even assigned the issue and you created a PR before that?

Saipradyumnagoud commented 1 day ago

@Saipradyumnagoud you were not even assigned the issue and you created a PR before that?

Yes sorry this will not be repated @himanshu-03

himanshu-03 commented 1 day ago

Please open an issue first @Saipradyumnagoud !

Saipradyumnagoud commented 1 day ago

Please open an issue first @Saipradyumnagoud !

this issue was opened by me @himanshu-03

himanshu-03 commented 1 day ago

Hey @Saipradyumnagoud !

image

While you replaced RP with rupee icon, the Rp in this link also got replaced. fix this and let me know

himanshu-03 commented 1 day ago

Great!

himanshu-03 commented 1 day ago

@himanshu-03 made the changes you requested

Why is there a dot ahead of each symbol? I dont think we should have a dot there

Saipradyumnagoud commented 1 day ago

@himanshu-03 made the changes you requested

Why is there a dot ahead of each symbol? I dont think we should have a dot there

should i remove even dot?

himanshu-03 commented 1 day ago

LGTM!