Anushkabh / krishiconnect

https://krishiconnect-mu.vercel.app/
MIT License
70 stars 171 forks source link

Enhanced Cart page #746

Closed Amruta7203 closed 2 months ago

Amruta7203 commented 3 months ago

Enhanced the Cart page:

  1. Removed content overflow
  2. Removed unwanted horizontal scroll bar
  3. reduced the opacity of background image for better visual appeal
  4. Created a semi transparent navbar instead of fully dark one

before: image image image

after: image image image

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
krishiconnect ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 1:59pm
Amruta7203 commented 3 months ago

Hello @himanshu-03 Review this PR and add relevant gssoc labels

himanshu-03 commented 3 months ago

Resolve merge conflicts @Amruta7203

Amruta7203 commented 3 months ago

@himanshu-03 This was a level 2 issue right?

himanshu-03 commented 3 months ago

@himanshu-03 This was a level 2 issue right?

It was because I thought you were saying of completely changing the page design. However only overflow and few stylings were updated.

himanshu-03 commented 3 months ago

@himanshu-03 This was a level 2 issue right?

It was because I thought you were saying of completely changing the page design. However only overflow and few stylings were updated.

Should I go merging with the PR?

Amruta7203 commented 3 months ago

@himanshu-03 should I make some more changes in the page then? Or you can suggest some..

RitiChandak commented 3 months ago

Hi @Amruta7203, the level may be adjusted after reviewing your work.

Please change these several things. the navbar image remove the opacity from the logo image Change the text color, or perhaps you've also applied the opacity feature to the image content also. image

Amruta7203 commented 3 months ago

@RitiChandak @himanshu-03 I have made the necessary changes..

  1. Changed the opacity
  2. Corrected font size for responsiveness
  3. Removed the unwanted space between navbar and logo

    Review and merge after adding relevant labels.

Amruta7203 commented 3 months ago

image

image

Screenshots for reference

himanshu-03 commented 3 months ago

@RitiChandak please review!

Amruta7203 commented 2 months ago

I have raised a new PR for the same @RitiChandak