Added decoder for URL. Also, added tests for dates and URLs.

Anviking / Decodable

[Probably deprecated] Swift 2/3 JSON unmarshalling done (more) right

MIT License

1.04k stars 73 forks source link

Added decoder for URL. Also, added tests for dates and URLs. #127

Closed codeOfRobin closed 7 years ago

codeOfRobin commented 7 years ago

@voidref Any more suggestions?

voidref commented 7 years ago

@codeOfRobin Just that the calls to decoder should be calls to decode instead. The decoder call isn't really meant to be a public interface, it's just there for customized parameter handling.

codeOfRobin commented 7 years ago

@voidref Done! 👍

voidref commented 7 years ago

LGTM, I am not a maintainer, just a contributor, so you'll need to wait for @Anviking to have time to review and merge. Thanks!

Anviking commented 7 years ago

LGTM too. Thanks, @codeOfRobin, and thanks, @voidref for reviewing!

Anviking commented 7 years ago

@voidref I just invited you as a repo collaborator also in case you want to!