Anvita2110 / pe

0 stars 0 forks source link

All numeric names can be added through add command #9

Open Anvita2110 opened 5 days ago

Anvita2110 commented 5 days ago

Problem: All numeric names can be added which should not be allowed

Steps to reproduce:

add n/21354576 p/98765432 e/johnd@example.com a/John street

Screenshot 2024-11-15 164812.png

soc-pe-bot commented 1 day ago

Team's Response

Thank you for raising this issue.

However, in our error message, we have stated that names should contain only alphanumeric and spaces, thus the given name 21354567 is a valid name.

image.png

However, we do recognize that it is not common for names to contain numbers and we will consider adding this check in the future.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This bug can't be rejected and neither can this be put into not in scope since:

  1. Given that you have accepted the shortcoming of the product - we do recognize that it is not common for names to contain numbers
  2. You have not mentioned it in planned enhancements

Hence it has to be accepted


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** **This is to be kept medium** since, your product allows for now which should have been mentioned in the UG. So, this can allow undesired values being entered by users and not even letting them know since there is no error thrown. ![photo_2024-11-17_20-14-23.jpg](https://raw.githubusercontent.com/Anvita2110/pe/main/files/48ccff0e-ce68-49b7-8939-874f4a9f9444.jpg)