Closed oliverschloebe closed 9 years ago
Partly implements #13
Hi,
first of all: thanks for your contribution! :) It's nice to see somebody working with the code.
I really like the general direction of the proposed changes. It looks so much cleaner than before, especially the typefaces. I tested your changes on my phone - please see below for feedback.
There are some things that need to be addressed before the request can get merged:
getChildView()
is called causes the list to stutter horribly. You should render the typefaces only once in the constructor: just move the Typeface.createFromAsset()
calls to the constructor of the ExpandableEventListAdapter
and everything becomes smooth again.event_list_type_padding_top
to 5dp
in res/values/dimens.xml
does the trick.If you fix the things listed above I will be happy to merge your request! (Please do, I really like it!) :)
Unfortunately, custom typefaces cannot be applied as easily to a RemoteView
so the widget's UI will differ a lot from the App UI. :-/
Issues have been addressed, Sir. :)
Thanks for accepting and merging the pull request and "reingehau'n"! ^^
Thanks, that looks good!
There is one more thing, however, that I didn't catch before: The notification logo does not look recognizable at all. I suggest to keep the current "RB" Text-Icon.
This is weird. The notification icon looks good on my OnePlus One running KitKat. Are you running Lollipop perhaps?
Yes, that is how it looks like on Lollipop and why I went for the "RB" text icon in the first place. I think monochrome notification icons are part of the design guidelines for 5.0+
Okay, using the PNG with the Android Asset Studio results in the same output: http://screens.schloebe.de/image_2015-02-23_15_20_57_001.png I guess the PNG file's corrupt or saved with incorrect specs.
Investigating...
Okay, reverted to previous icons + removed obsolete reminder icons.
Hi,
here's my first pull request changing the UI a little so it's a little more clean and friendly. :-)
Before:
![Before](http://i.imgur.com/5MoEVbt.png =100x20)
After:
Changelog: