GCC fix and tiny cleanup

AnyDSL / thorin

The Higher-Order Intermediate Representation

https://anydsl.github.io

GNU Lesser General Public License v3.0

151 stars 15 forks source link

GCC fix and tiny cleanup #112

Closed PearCoding closed 3 years ago

PearCoding commented 3 years ago

Fix of the issue #111 and fix for the Preprocessor definition of DLOG, which, with NDEBUG defined, does produces incorrect code.

Also cleaned up some "function does not return value" and "switch case break" issues. Keep in mind that those "fixes" do not change program flow or any other logic, as all the "fixes" appear after asserts, which should trigger an abort anyway. They are only there to please the compiler.

madmann91 commented 3 years ago

Hi! Can you please move the line int id() const { return id_; } to inside the THORIN_ENABLE_CHECKS ifdef? Then I'll merge this.

PearCoding commented 3 years ago

I just did it. :)