AnyDSL / thorin

The Higher-Order Intermediate Representation
https://anydsl.github.io
GNU Lesser General Public License v3.0
151 stars 15 forks source link

cleanup cleanup #142

Open michael-kenzel opened 12 months ago

michael-kenzel commented 12 months ago

While working on the plugin system, I had to add some stuff to the Importer and cleaned up a little (mostly inconsistent uses of the world() vs world_ members, I wanted to remove the world() member and make the rest private, but it seems the hls stuff uses it all over the place so I left it public for now).

Hugobros3 commented 12 months ago

Please have a look at the development branch and base any changes off it. Of note, I added a Thorin class that effectively holds the world, rather than the world "holding itself" (which makes dumping/diffing two versions of the world impossible)

https://github.com/AnyDSL/thorin/blob/development/src/thorin/world.h#L394

michael-kenzel commented 11 months ago

I revisited these changes. It's now only cleaning up inconsistent uses of the world() vs world_ members.