Implemented inline assembly

[leissa]

Hi,

the patch looks nice :)

Some minor technical remarks:

• I think Asm would be the perfect name for this node, but since asm is already a C++ keyword I suggest Assembly - this is less cryptic than inl_asm and then we can use assembly as variable name
• use Types instead of std::vector<const Type*>&
• use Defs instead of std::vector<const Def*>&
• use ArrayRef<std::string> instead of std::vector<std::string> in the constructor and Array<std::string> instead of std::string<std::string> as member.
• simply assume that the input tuple already has 'mem' as first element. You can offer a second factory method in World where mem can be specified as extra input item.
• same story for the output types.
• remove the default constructor arguments - they are useless because the user can only use the factory method
• to be consistent, the const Location& loc should be the last argument.
• I think it would be better to have an appropriate enum with all flags instead of passing a ton of boolean flags - it's also easier to add further flags if this is desired.

To sum it up, the constructor should look like this:

Assembly(const Type* type, Defs input, std::string asm_template, ArrayRef<std::string> output_constraints, ArrayRef<std::string> input_constraints, ArrayRef<std::string> clobbers, Flags flags, const Location& loc)

Same story for the factory method + a second method which looks like this:

assembly(Types types, const Def* mem, Defs input, std::string asm_template, ArrayRef<std::string> output_constraints, ArrayRef<std::string> input_constraints, ArrayRef<std::string> clobbers, Flags flags, const Location& loc)

[tillspeicher]

I addressed all the issues, it should be ready to merge now.

[leissa]

I've also polished a bit and fixed some potential problems. Can you plz have a look at my chagnes that I didn't break anything? Note that I have removed the static method get_flags. Simply use, for instance: HasSideEffects | IsAlignStack. Maybe, you want to reuse in impala the same enum. So you don't have to convert stuff.

[tillspeicher]

I'm just updating Impala based on the changes you made. Using the Flags enum there would be nice, but then we need to include primop.h in ast.h which I guess we don't want. In this case we should move the enum somewhere else and include that. Is enums.h the right place for that?

[leissa]

Simply include primop.h. That's fine.