AnyOldName3
commented
1 year ago There are a bunch of superfluous-looking changes, and it's hard to tell what they are because the diff's busted as you've changed all the line endings from LF to CRLF. You've probably not got autocrlf enabled.
I've got some feedback based on what I can see immediately, though:
- The change in PyQt version is inherently going to remove compatibility with Qt5-based MO2 versions, so all the compatibility fallbacks that make it work with versions as far back as 2.1.6 should be stripped out.
- This is a breaking change, so the version needs to be increased to 4.0 instead of decreased back to 3.0, and as there's no release or beta, it should be marked as alpha.
- It's easier to track regressions if the different kinds of change are in separate commits rather than bundled together, e.g. one commit changes to PyQt6 and does the minimum to get it to launch in 2.5, and a separate one takes advantage of the non-mandatory modernisation opportunities like stripping out compatibility fallbacks and switching integers to enums.
Using mobase-stubs-2.5.0.dev10 Updated to pyQt6. Generates text into a filled and empty Openmw.cfg.
Converted a few imports to use full names, a few interfaces are moved from IOrganizer to IModList.