search

AnyOldName3 / modorganizer-installer_omod

OMOD installer using https://github.com/erri120/OMODFramework
GNU General Public License v3.0
2 stars 3 forks source link

Add progress dialogs #1

Closed Holt59 closed 4 years ago

Holt59 commented 4 years ago

Few "problems":

  1. None of the dialog of cancelable, I even disable the close button because I have no idea how to cancel the process (kill the task? throw an exception?).
  2. The message popup seems to block the QMainWindow, probably because the dialog are application-modal instead of window-modal.
  3. There are still some times during the installation process where the framework is doing thing but the user is free to do what he wants, in particular right before extraction.
AnyOldName3 commented 4 years ago

Can you cherry-pick the three features here into separate PRs so I can merge the bits I'm happy with while we sort out the rest?

AnyOldName3 commented 4 years ago

Also I made a merge conflict by moving DisplayText onto the main thread. Once you resolve that, you shouldn't get the deadlock when it gets called that you were seeing and we can answer the is DisplayText modal with these changes question.

AnyOldName3 commented 4 years ago

I've made an even bigger merge conflict by cherry-picking the Initialising OMOD installer... dialogue into frednet.

AnyOldName3 commented 4 years ago

This is redundant