Closed rimas-kudelis closed 4 years ago
@menny is there anything that's preventing you from reviewing PRs?
@rimas-kudelis it looks good, and I'll gladly merge this. Just a question about the pack ownership (see inline)
@menny I can transfer ownership of the pack to you or @friesenkiwi or some other account you guys control. I'd love to keep access to publish it myself too if possible, but if not, that's fine by me.
Also, I commented about the signing key in my initial comment. Do you have it already or should I send it your way?
@menny ping
So, if you want me to publish, please email me the signing key to menny@evendanan.net
I can't give access to publish ATM, but it will be automatically published once hitting master
Also, until I have the keys and ser them up correctly in the secrets mechanism, I can not publish this. Can you switch the publish flag to false
?
@menny I've sent the key your way. Assuming that the actual transfer of ownership of the package on Google Play is the only thing that's left now, I guess we could wait with merging until that is done and avoid flipping the flag? Would that work for you?
sure. Follow the guide here: https://support.google.com/googleplay/android-developer/answer/6230247?hl=en I'll send you my details over email
@menny could you resend me your details (play console email address and order id)? I was unable to transfer the ownership of the package using the details you provided me with previously. :(
@rimas-kudelis I replied to your email about the ownership. Let me know if the new details work for you.
Thanks! The app transfer is now pending.
Now all that's left is to delete the Lithuanian branch. :)
This PR contains the following changes:
I have released this update in Google Play already (https://play.google.com/store/apps/details?id=org.herrlado.ask.languagepack.lithuanian) and marked it as beta for now.
Regarding dictionaries: I've left both the AOSP and the one we used originally in the source, but with AOSP, our originally produced dictionary might actually be unnecessary (especially since it's isn't really Apache licensed).
The release process currently expects a key named "lithuanian" in the key store. I used Lado's key to sign it (key fingerprint is A0:C8:20:B7:F4:42:8B:0A:E4:C1:B0:15:F5:FF:2F:E9:36:A9:29:0F), which I suspect is probably same as the key used for Czech language pack. @menny I can forward the key to you if you don't have it.