search

AnyarInc / Ascent

A fast and flexible C++ simulation engine and differential equation solver.
Apache License 2.0
123 stars 15 forks source link

Ubuntu compilation failure due to missing <memory> #18

Closed WenyinWei closed 2 years ago

WenyinWei commented 3 years ago

Hi guys, I have been stuck in the compilation stage, encountering some trouble with the very latest compiler suite and CMake version. Maybe we can set some prerequisites in README, e.g. CMake 3.12 and gcc-8, to tell users what they need before using Ascent, as Ascent uses many fancy and modern C++ style codes.

Even equipped with the newest compiler, I still met the following failure, which told me I need to add #include <memory> in unit_test. Fortunately, everything goes well after I prepended it. Maybe we also need to add some automatic CI workflow check to ascent.

image

Compilation on Windows platform runs swiftly and comfortably, awesome ascent, thx!

stephenberry commented 3 years ago

Thanks for your feedback. I definitely want to add more CI. My team tests code on GCC, but I'm not sure the last version that is supported. I'll try to make the prerequisites more clear. Sincerely, Stephen

stephenberry commented 2 years ago

The issue of the missing <memory> include has been resolved in a recent commit. I still plan to add CI soon. Thanks for pointing out this error.