search

AnyarInc / Ascent

A fast and flexible C++ simulation engine and differential equation solver.
Apache License 2.0
123 stars 15 forks source link

Make Timing::sample const and change asc::ChaiScript constructors #19

Closed cavalos-anyar closed 2 years ago

cavalos-anyar commented 2 years ago

Timing::sample can be made const without consequence as it doesn't modify.

Ascent's version of ChaiScript declares copy/move constructors/assignments as default. When I compiled Ascent's ChaiScript under clang, I received multiple warnings that these functions are implicitly deleted: /ascent/include/ascent/ChaiEngine.h:117:19: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted] ChaiEngine& operator=(ChaiEngine&&) = default; ascent/include/ascent/ChaiEngine.h:114:7: warning: explicitly defaulted copy constructor is implicitly deleted [-Wdefaulted-function-deleted] ChaiEngine(const ChaiEngine&) = default; and so on...

stephenberry commented 2 years ago

Thanks!