search

AnyhowStep / tsql

A SQL query-builder/ORM
37 stars 3 forks source link

Many changes; empty grouping set support; HAVING clause requires non-… #172

Closed AnyhowStep closed 4 years ago

AnyhowStep commented 4 years ago

…empty GROUP BY clause; ORDER BY clause checks GROUP BY; SELECTing aggregate expr implies empty grouping set

The past few PRs have been really large because I keep thinking up of possible edge cases, and getting the urge to fix them all at once. The code is getting uglier and uglier because I'm focusing on fixing edge cases, rather than maintainability, at the moment.

I'll have to clean up the code at some point...

AnyhowStep commented 4 years ago

Didn't focus too much on run-time tests; will have to add more later

AnyhowStep commented 4 years ago

codecov seems to be broken. It isn't yelling at me or giving me a status report. https://codecov.io/gh/AnyhowStep/tsql/commit/c833ce88995c52e76ff36652a66a80a65568a790

AnyhowStep commented 4 years ago

I'm just gonna' merge, even if it'll lower overall coverage. Coverage at the moment doesn't look too bad.