search

AoTTG-2 / AoTTG-2

The community wants a sequel, and so we are going to make it reality! #AoTTG2
Other
274 stars 56 forks source link

Dynamic Sky Toggle #585

Closed FAStre closed 3 years ago

FAStre commented 3 years ago

How will this enhancement improve the game? While testing the time and lighting system, I noticed that putting a static skybox instead of a procedural one makes quite a noticeable difference in fps. I propose adding another toggle to the time and lighting settings that will toggle whether a dynamic sky is enabled or not. When not enabled, the skybox will be one of 3, either a dawn, afternoon or night skybox, that will be applied at certain times in the day.

Describe the solution you'd like

Additional context (Remove if not relevant) This toggle will help with performance of the new dynamic lighting implemented in AoTTG2. I have already done a small test run of this in the #113 branch, it would not be a lot of effort to implement it.

Contributor instructions (Do not modify)

  1. Determine if the enhancement is compatible with existing features
  2. If the idea is denied, please provide a reason and close the issue. If the idea is accepted, consult your team to do an estimation of effort. Remove the [PROPOSAL] name and label.
  3. Move the issue to the Future Milestone. On rare exceptions an issue may be moved to Release if there's sufficient upvotes.
  4. Once the issue matches the current milestone, follow development procedures.
github-actions[bot] commented 3 years ago

This issue is stale because it has been open 15 days with no activity. Remove stale label or comment