search

Aohzan / ecodevices

Home Assistant custom component for GCE Eco-Devices
Apache License 2.0
14 stars 4 forks source link

Add authentication support #2

Closed trasher closed 3 years ago

trasher commented 3 years ago

My Eco-Devices is protected with the password it provides (simple HTTP authentication).

I've never worked on a home assistant component before; but I've been able to make it work :)

Aohzan commented 3 years ago

Hello @trasher, thanks for the PR, I will try this week-end on my ecodevices

Aohzan commented 3 years ago

Tested and approved, I let you see my review, I will merge after that :)

trasher commented 3 years ago

Tested and approved,

Cool :)

I let you see my review, I will merge after that :)

Hum... Your review? Maybe you forget to submit it?

Aohzan commented 3 years ago

I will close this PR since I began a full rewrite with your modification: https://github.com/Aohzan/ecodevices/pull/4 You can contribute on it if you wants