Aohzan / ipx800

IPX800 V4 integration for Home-Assistant
Apache License 2.0
20 stars 12 forks source link

Proposal to fix errors coming from the IPX #15

Closed guigeek38 closed 3 years ago

guigeek38 commented 3 years ago

I was able to test these changes on my setup and everything seems to work. I have no more errors. What do you think about these changes?

Aohzan commented 3 years ago

Great job, thank you !

Aohzan commented 3 years ago

@guigeek38 it seems not working as expected, if I turn off all light, some request are not send to the ipx800

I still get the issue with the state timeout on lovelace by the way

guigeek38 commented 3 years ago

@guigeek38 it seems not working as expected, if I turn off all light, some request are not send to the ipx800

On my setup, I haven't had any errors since I put this fix in place. However, my setup uses the async version of all calls (before rollbacks), and I applied the fix I suggested for pypx800 in the PR: https://github.com/Aohzan/pypx800/pull/1. I was able to do network captures (with Wireshark and Tcpdump) and all my requests are sent one after the other to the IPX800. Do errors occur in deterministic ways on your setup? If so, is it possible to do a network capture to see what's going on?

I still get the issue with the state timeout on lovelace by the way

I also had some bugs despite this change. I think the right solution as you say is to pass REQUEST_REFRESH_DEFAULT_IMMEDIATE to True, in order to avoid deboucing...