Can't read sysinfo with unicode caracter

AonCyberLabs / Windows-Exploit-Suggester

This tool compares a targets patch levels against the Microsoft vulnerability database in order to detect potential missing patches on the target. It also notifies the user if there are public exploits and Metasploit modules available for the missing bulletins.

GNU General Public License v3.0

3.94k stars 1.02k forks source link

Can't read sysinfo with unicode caracter #1

Closed anarcheuz closed 10 years ago

anarcheuz commented 10 years ago

Hi,

It can't read the sysinfo I generated from my windows 8.1 french version.

sammbertram commented 10 years ago

Hi anarcheuz,

Firstly thanks for the bug report. Do you mind sharing your systeminfo output? I haven't tested on non-English systeminfo input but would like to see what it looks like.

Feel free to sanitise as you see fit (IP address, hostname, product ID, etc) and can post here.

Sam

sammbertram commented 10 years ago

As a temporary workaround until language independent OS detection has been created the --ostext flag can be used. This flag forces OS detection so it will not rely on the parsing of the "systeminfo" input. The --ostext flag can be a loose representation of the target operating system, such as "windows 8.1 64-bit". This should only affect non-English Windows "systeminfo" output until I can implement fully language independent OS detection.

sammbertram commented 10 years ago

This issue should now be closed. I have added better input detection when opening unknown file (encoding) formats, additionally the tool should now be able to parse non-English systeminfo input.