ApacheThunder / NTR_Launcher_Old

NTR Launcher - Bring back classic DS boot animation + boot older flashcarts!
GNU General Public License v3.0
20 stars 2 forks source link

Add libraries as git sub-modules #2

Closed DanTheMan827 closed 8 years ago

DanTheMan827 commented 8 years ago

I think it would be better to add the fork of libnds and maxmod as git sub-modules.

It's your choice but it definitely makes it easier to compile.

ApacheThunder commented 8 years ago

While I support the idea of doing this, I may hold off on it. I primarilly use Github's desktop app to push updates/sync changes. The issue is they STILL have not fixed the issue where it can't correctly sync changes to submodules. While I imagine this can be done via the command line tools, I'm not familiar with them right now. If ahezard updates libnds, then I will have problems syncing the changes on my computer because the desktop app has trouble doing this correctly. :(

DanTheMan827 commented 8 years ago

There's a really good reason for not automatically updating sub-modules...

Imagine you had an app that was using a specific version of a library and the new one wasn't compatible... or if you add the newest version of a library and then they go ahead change the usage...

I personally prefer SourceTree over the GitHub app since that easily allows you to checkout the newest commits of sub-modules

To make the sub-module commit stick you would open the terminal and type

git add -A libnds
ApacheThunder commented 8 years ago

I'll go ahead and merge this, but only for NTR Launcher. But it's likely I'll only do this for this project. The alt branch of NTR Launcher won't have this (unless you pull request that one too). It's not just that github doesn't handle submodules very well, it's extra stuff I have to keep track of and am not a fan of doing that. :P

ApacheThunder commented 8 years ago

And...I have to manually download the modules. That's just ***king great. God I hate this thing. :P

ApacheThunder commented 8 years ago

I don't know how to have it download submodules. So my only method for this that's convienient for me is to delate everything off my local github folder and have it clone everything again. Submodules are really inconvenient to work with in Github's program which is why I try to avoid them.

DanTheMan827 commented 8 years ago

Like I said, your choice...

Also, the GitHub client is pretty bad...

I really think SourceTree would work well for you...

It's easy to use for simple stuff but it handles more complicated stuff as well (mostly automatically)

ApacheThunder commented 8 years ago

Yep rolling this back. Now anytime I compile this, it wants to compile libnds and max mod. this thing already takes forever to compile. maybe when I'm using a new boot splash system I'll reconsider this, but not ready for this.

DanTheMan827 commented 8 years ago

It should only compile libnds and maxmod the first time (unless you clean)

it's easy enough to make the libs separate from the main compile

ApacheThunder commented 8 years ago

I clean often to keep things tidy. It's going to be an issue for me. Plus I have other projects that use ahezard's libnds that may not get these as submodules so it may introduce inconsistancies if I end up updating libnds for one project while everything else I accidently compile on an older version. Not worth the trouble right now. :(

DanTheMan827 commented 8 years ago

Okay

ApacheThunder commented 8 years ago

You're free to do this for your own projects that use NTR Launcher. I just personally will not do this with my own. Too much stuff for me to keep track of and I just despise how github handles this. I'd use other ways of maintaining this...But I'd have to learn how to maintain it with that other program(s). I'm not motivated enough to do this that way.

DanTheMan827 commented 8 years ago

Like I said, just a suggestion

ApacheThunder commented 8 years ago

Yeah. Thanks for the suggestion though. I recognize it's probably the right way to handle this. I don't have much issue dealing with submodules for other projects. But dealing with them for my own projects is a whole other can of worms I'm not willing to deal with right now. :P

ApacheThunder commented 8 years ago

Well on the plus side it's in my commit history now, so users could download them via that if they need to. :D