Simpler array bounds checking

AparokshaUI / adwaita-swift

A framework for creating user interfaces for GNOME with an API similar to SwiftUI

https://aparokshaui.github.io/adwaita-swift/

MIT License

749 stars 16 forks source link

Simpler array bounds checking #7

Closed ZevEisenberg closed 3 months ago

ZevEisenberg commented 3 months ago

Steps

[x] Add your name or username and a link to your GitHub profile into the Contributors.md file.
[ ] Build the project on your machine. If it does not compile, fix the errors.
[x] Describe the purpose and approach of your pull request below.
[x] Submit the pull request. Thank you very much for your contribution!

Purpose

This is a slightly simpler and possibly more idiomatic way to check array bounds using the array's built-in indices collection.

Approach

See above.

ZevEisenberg commented 3 months ago

I wasn't able to build on my machine, possibly because I'm on a Mac?

ZevEisenberg commented 1 week ago

Apologies for the delay! Here's a screenshot of the errors I see, and some detail on the first one in the build log. I'm assuming I need some dependency installed, but the readme didn't mention anything that I could see. I installed libadwaita via homebrew, but it didn't help.

david-swift commented 1 week ago

This is probably the same problem as reported in https://github.com/AparokshaUI/adwaita-swift/issues/32. Unfortunately, we haven't yet been able to fix it (but it should work with swift run instead of Xcode's run button). Maybe you could try the steps in https://github.com/AparokshaUI/adwaita-swift/issues/11#issuecomment-2026804538, I don't know whether this helps (in general, I'd recommend installing Linux on the device or in a VM to work with Libadwaita).