search

Ape / samsungctl

Remote control Samsung televisions via a TCP/IP connection
MIT License
713 stars 191 forks source link

changed key_interval from 1sec to 0.5sec #43

Closed StancuFlorin closed 6 years ago

StancuFlorin commented 7 years ago

This is the solution for this issue: https://github.com/Ape/samsungctl/issues/40

Ape commented 7 years ago

The previous 1 second interval is probably way too long. I'm quite sure that I am going to merge is PR. However, since I am not using the websocket backend myself I would like to have somebody else test how this change behaves on their TV model and use case.

In addition, I would like to have more experiences about the correct interval value. Is 0.2 seconds too little? What is the safest choice here?

eclair4151 commented 6 years ago

i have tested this an i have found that .25 seconds works fine on websockets. 1 second is way to long

Ape commented 6 years ago

Please make a pull request with 0.25 seconds and I will merge it. Or please say if you have further experiences about what would be the correct value.

eclair4151 commented 6 years ago

after more testing i think half a second is better. when i made it 0.25 seconds i started to loose commands if i sent 10 in a row. but at 0.5 i never had an issue. i think you are prob fine to just merge this PR

Ape commented 6 years ago

Thanks. It's a bit difficult for me to handle websocket features because I cannot test them myself.