ApeWorX / ApePay

A smart contract payment system built for automated service management
https://apeworx.io/apepay
Apache License 2.0
19 stars 6 forks source link

fix: time_left max C int issue [SBK-338] #67

Closed mikeshultz closed 11 months ago

mikeshultz commented 11 months ago

This prevents the python sdk from attempting to overflow when instantiating timedeta objects with exceptionally long-funded streams. The effective limit is like 220k years so even though the accuracy is reduced, humanity will probably have ascended to the stars by that point.

Fixes #65

linear[bot] commented 11 months ago
SBK-338 "fix: time_left max C int issue" (ApeWorX/ApePay #67)

This prevents the python sdk from attempting to overflow when instantiating timedeta objects with exceptionally long-funded streams. The effective limit is like 220k years so even though the accuracy is reduced, humanity will probably have ascended to the stars by that point. Fixes #65 --- [ApeWorX/ApePay #67](https://github.com/ApeWorX/ApePay/pull/67) by [mikeshultz](https://github.com/mikeshultz) on GitHub *via LinearSync*

mikeshultz commented 11 months ago

Was there just some weird test data or something causing this?

I didn't really look into who created it or why (see #65). It's probably not something we'd see on a prod deployment with USDC because it's only 6 decimals, but I could see it being an accident with an 18 decimal token.