feat: private transaction [APE-1079]

ApeWorX / ape-alchemy

Alchemy network provider plugin for the Ape Framework

https://www.apeworx.io/

21 stars 13 forks source link

feat: private transaction [APE-1079] #55

Closed antazoey closed 1 year ago

antazoey commented 1 year ago

What I did

Fixes: APE-1079

How I did it

How to verify it

Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

linear[bot] commented 1 year ago

APE-1079 "feat: private transaction" (ApeWorX/ape-alchemy #54)

### What I did is there a way to properly test this without spending Eth on mainnet? ### How I did it ### How to verify it ### Checklist * [ ] Passes all linting checks (pre-commit and CI jobs) * [ ] New test cases have been added and are passing * [ ] Documentation has been updated * [ ] PR title follows [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/) standard (will be automatically included in the changelog) --- [ApeWorX/ape-alchemy #54](https://github.com/ApeWorX/ape-alchemy/pull/54) by [antazoey](https://github.com/antazoey) on GitHub *via LinearSync*

antazoey commented 1 year ago

Well I can't find a way to test this without actually sending ETH which I am not willing to do, so someone else let me know if this works and if it doesn't go and ahead and fix it, will care later if i ever time.

antazoey commented 1 year ago

Ok I lied, I tried it out... I got it to send, but was not able to get the receipt for some reason, it was never found.

Do you think we need to use a higher txn acceptance timeout for private txns or something?

antazoey commented 1 year ago

So it is actually working, but we were a little wrong....

On Alchemy, for private txns, the receipt comes back as null with a 200 response.

antazoey commented 1 year ago

OK doing some research, this stuff takes a while... Like Alchemy is going try and get this published for the next 25 blocks. Going to just set a huge timeout for now, but will be a lot better once we have async receipts

fubuloubu commented 1 year ago

OK doing some research, this stuff takes a while... Like Alchemy is going try and get this published for the next 25 blocks. Going to just set a huge timeout for now, but will be a lot better once we have async receipts

Yeah, the ability to have immediate receipt object and then be able to do await receipt or (synchronously) receipt.wait_for_confirmation() would be really sweet