feat: adding import functionality

ApeWorX / ape-aws

Plugin to interact with AWS for transactions on the Ethereum Blockchain

Apache License 2.0

2 stars 0 forks source link

feat: adding import functionality #13

Closed johnson2427 closed 2 months ago

johnson2427 commented 2 months ago

What I did

Adding import for Eth private keys to AWS KMS

fixes: #12

How I did it

Added functionality, trying to emulate This Article in python

How to verify it

ape aws kms import 'testAlias' 'Description' 'private-key'

Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

johnson2427 commented 2 months ago

Overall a bit confused why we are storing the private keys on disk once they are imported

I built out the ability to allow ape-aws to create a key for the user just to give us a visual of what that would look like in case it was something you may have wanted. I originally built out this functionality to get a key in the correct format so I knew what I was dealing with, with respect to KMS. KMS has different requirements for key formats, and with the requirement of needing to use the public key and private key together to encrypt the private key to send, I needed to know what KMS was looking for. After building out the feature, I figured I'd let you look at it to see if it was something you wanted. If you did want it, we needed the ability to store that key.

johnson2427 commented 2 months ago

Does this actually display on your machine? I hadn't seen this before

which are you referring to?

fubuloubu commented 2 months ago

Does this actually display on your machine? I hadn't seen this before

which are you referring to?

Where it was saying SUCCESS (ape-aws): ..., I don't think that the (ape-aws) actually shows up in the display

johnson2427 commented 2 months ago

Does this actually display on your machine? I hadn't seen this before

which are you referring to?

Where it was saying SUCCESS (ape-aws): ..., I don't think that the (ape-aws) actually shows up in the display

oh, yeah that was showing up in my returns, but if it isn't showing up in yours, I'm not too worried about it

fubuloubu commented 2 months ago

Does this actually display on your machine? I hadn't seen this before

which are you referring to?

Where it was saying SUCCESS (ape-aws): ..., I don't think that the (ape-aws) actually shows up in the display

oh, yeah that was showing up in my returns, but if it isn't showing up in yours, I'm not too worried about it

I didn't actually try it, might be a new feature of Ape v0.8