fix: Allow NONE licenses without logging errors (also completes comments for license types)

ApeWorX / ape-etherscan

Etherscan explorer plugin using EVM-based networks for the Ape Framework

https://www.apeworx.io/

Apache License 2.0

21 stars 25 forks source link

fix: Allow NONE licenses without logging errors (also completes comments for license types) #118

Closed sreyemnayr closed 1 month ago

sreyemnayr commented 4 months ago

What I did

Added keys for intentionally unlicensed (not to be confused with the "Unlicense" 🙃 ) source code without an error.

fixes: #

How I did it

How to verify it

Checklist

[x] Passes all linting checks (pre-commit and CI jobs)
[x] New test cases have been added and are passing
[x] Documentation has been updated
[x] PR title follows Conventional Commit standard (will be automatically included in the changelog)

antazoey commented 4 months ago

Yes, this lgtm, the UI offers the same so it makes sense.

mikeshultz commented 3 months ago

@sreyemnayr is there anything you need to get this across the line?

sreyemnayr commented 3 months ago

Just time and a nudge 😄 will try to get it tomorrow!

On Fri, Mar 29, 2024 at 2:02 PM Mike Shultz @.***> wrote:

@sreyemnayr https://github.com/sreyemnayr is there anything you need to get this across the line?

— Reply to this email directly, view it on GitHub https://github.com/ApeWorX/ape-etherscan/pull/118#issuecomment-2027624567, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBJQTVNBYALB5YKLYYA3TLY2W3FNAVCNFSM6AAAAABEHQXELKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXGYZDINJWG4 . You are receiving this because you were mentioned.Message ID: @.***>

fubuloubu commented 2 months ago

ah crap @antazoey, looks like plugins need the treatment of https://github.com/ApeWorX/ape/pull/2020 as well

antazoey commented 2 months ago

ah crap @antazoey, looks like plugins need the treatment of ApeWorX/ape#2020 as well

Yes, they do, everything does! It's horrendous. The issue has been open with Github for so long.

antazoey commented 2 months ago

ah crap @antazoey, looks like plugins need the treatment of ApeWorX/ape#2020 as well

here is this one: https://github.com/ApeWorX/ape-etherscan/pull/126 I am not going to fix all 300 of our python packages; we will just fix them as they come up.

antazoey commented 2 months ago

all test fixes here: https://github.com/ApeWorX/ape-etherscan/pull/127

github-actions[bot] commented 1 month ago

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

sreyemnayr commented 1 month ago

Is there something else that needs doing now that the tests are fixed?

On Thu, May 23, 2024 at 8:47 PM github-actions[bot] < @.***> wrote:

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

— Reply to this email directly, view it on GitHub https://github.com/ApeWorX/ape-etherscan/pull/118#issuecomment-2128338500, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBJQTWVIIW2236J6PKPJ2LZD2L33AVCNFSM6AAAAABEHQXELKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRYGMZTQNJQGA . You are receiving this because you were mentioned.Message ID: @.***>

mikeshultz commented 1 month ago

@sreyemnayr sorry, missed your review request. Changes LGTM.

@antazoey looks like there's still some test issues here? We need to set an infura key for this repo?

fubuloubu commented 1 month ago

@antazoey looks like there's still some test issues here? We need to set an infura key for this repo?

New contributors don't have access to our secrets, so just need to check it out of band

mikeshultz commented 1 month ago

Confirmed tests pass, but I can't merge this because passing tests are required. @fubuloubu you want to merge this?