ApeWorX / ape-etherscan

Etherscan explorer plugin using EVM-based networks for the Ape Framework
https://www.apeworx.io/
Apache License 2.0
21 stars 25 forks source link

False positive for "Etherscan API server rate limit error" #122

Closed BlinkyStitt closed 5 days ago

BlinkyStitt commented 4 months ago

Environment information

$ ape --version
0.7.11.dev9+ga8d1487d

$ ape plugins list
Installed Plugins
  alchemy         0.7.1
  ens             0.7.0
  etherscan       0.7.1
  foundry         0.7.4.dev6+ga535421
  ganache         0.7.0
  hardhat         0.7.0
  infura          0.7.1
  polygon         0.7.1
  solidity        0.7.1
  template        0.7.0
  tokens          0.7.1
  vyper           0.7.0

Third-party Plugins
  flashprofits    0.0.1
  roll            0.0.3

What went wrong?

I am tracing a transaction that calls some contracts that are not verified. The error message is incorrect and the red "ERROR" is rather scary.

ERROR: Unable to fetch contract type at '0xf081470f5C6FBCCF48cC4e5B82Dd926409DcdD67' from explorer.
Response indicated failure: Etherscan API server rate limit exceeded.

If ETHERSCAN_API_KEY is not set, the error message is slightly different (and has a minor typo with two periods):

Response indicated failure: Etherscan API server rate limit exceeded.. Try setting ETHERSCAN_API_KEY'.

How can it be fixed?

The error detection needs to distinguish between a contract without verified code and a rate limit error.

linear[bot] commented 4 months ago

APE-1703 False positive for "Etherscan API server rate limit error"

linear[bot] commented 4 months ago

APE-1707 False positive for "Etherscan API server rate limit error"

fubuloubu commented 4 months ago

transferred issue to correct plugin