fix: allow getting contract types for non-checksummed addresses - Githubissues

ApeWorX / ape-etherscan

Etherscan explorer plugin using EVM-based networks for the Ape Framework

https://www.apeworx.io/

Apache License 2.0

24 stars 26 forks source link

fix: allow getting contract types for non-checksummed addresses #56

Closed antazoey closed 1 year ago

antazoey commented 1 year ago

What I did

Was unable to get contract types when address was not checksummed and I got confused.

How I did it

Check if address type (which checks if checksum) and if not, convert it.

How to verify it

address.lower() <-- use this as a value

Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

antazoey commented 1 year ago

https://github.com/ApeWorX/ape-etherscan/pull/58 oops