ApeWorX / ape-etherscan

Etherscan explorer plugin using EVM-based networks for the Ape Framework
https://www.apeworx.io/
Apache License 2.0
24 stars 26 forks source link

feat: add support for using Etherscan as a Query Engine [APE-636] #71

Closed fubuloubu closed 1 year ago

fubuloubu commented 1 year ago

What I did

Partially a realization that Etherscan already has support for several of the types of queries that are supported in our core data query model, so just enabling support for that

How I did it

Copy-pasted code from this PR: https://github.com/ApeWorX/ape/pull/1277

How to verify it

Install Etherscan plugin and it works with account.history requests

Checklist

linear[bot] commented 1 year ago
APE-636 "feat: add support for using Etherscan as a Query Engine" (ApeWorX/ape-etherscan #71)

### What I did Partially a realization that Etherscan already has support for several of the types of queries that are supported in our core data query model, so just enabling support for that ### How I did it ### How to verify it ### Checklist * [ ] Passes all linting checks (pre-commit and CI jobs) * [ ] New test cases have been added and are passing * [ ] Documentation has been updated * [ ] PR title follows [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/) standard (will be automatically included in the changelog) --- [ApeWorX/ape-etherscan #71](https://github.com/ApeWorX/ape-etherscan/pull/71) by [fubuloubu](https://github.com/fubuloubu) on GitHub *via LinearSync*

fubuloubu commented 1 year ago

Side note: migrate https://github.com/ApeWorX/ape/issues/965 to this repository once this PR is merged

antazoey commented 3 months ago

This PR was missing documentation and even though the box got checked. I am going to add it now because I forget entirely how to use this feature and I need to call the API that is now hidden behind the query manager