ApeWorX / ape-etherscan

Etherscan explorer plugin using EVM-based networks for the Ape Framework
https://www.apeworx.io/
Apache License 2.0
24 stars 26 forks source link

refactor: remove unused function from ExplorerAPI subclass [APE-638] #72

Closed fubuloubu closed 1 year ago

fubuloubu commented 1 year ago

What I did

depends on: https://github.com/ApeWorX/ape/pull/1305

How I did it

How to verify it

Checklist

linear[bot] commented 1 year ago
APE-638 "refactor: remove unused function from ExplorerAPI subclass" (ApeWorX/ape-etherscan #72)

### What I did depends on: [https://github.com/ApeWorX/ape/pull/1305](https://github.com/ApeWorX/ape/pull/1305) ### How I did it ### How to verify it ### Checklist * [ ] Passes all linting checks (pre-commit and CI jobs) ~- \[ \] New test cases have been added and are passing~ ~- \[ \] Documentation has been updated~ * [X] PR title follows [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/) standard (will be automatically included in the changelog) --- [ApeWorX/ape-etherscan #72](https://github.com/ApeWorX/ape-etherscan/pull/72) by [fubuloubu](https://github.com/fubuloubu) on GitHub *via LinearSync*

fubuloubu commented 1 year ago

NOTE: 95932b2 is the solution to a long-standing bug I've had with etherscan (it kept missing nonce 0 receipts)

fubuloubu commented 1 year ago

Just going to double check this one against the latest release

fubuloubu commented 1 year ago

Works with latest release

antazoey commented 1 year ago

linting concerns hopefully addressed now from main branch changes