ApeWorX / ape-etherscan

Etherscan explorer plugin using EVM-based networks for the Ape Framework
https://www.apeworx.io/
Apache License 2.0
24 stars 26 forks source link

feat: add Avalanche Fuji testnet support [APE-705] #73

Closed PoCk3T-SPAI closed 1 year ago

PoCk3T-SPAI commented 1 year ago

What I did

As per https://docs.snowtrace.io/v/fuji-snowtrace, adding the Etherscan/Snowtrace API for Avalanche Fuji testnet in client.py

Checklist

PoCk3T-SPAI commented 1 year ago

@fubuloubu humble contribution here I've identified 4 files where additions needed to be made to support the Fuji testnet of Avalanche Hope I didn't miss to update any other file Let me know your thoughts

PoCk3T-SPAI commented 1 year ago

@fubuloubu thanks for the prompt action; 2 CI/CD tests seem to have failed:

fubuloubu commented 1 year ago

@fubuloubu thanks for the prompt action; 2 CI/CD tests seem to have failed:

  • Lint -> not sure what's the hold up, I followed the exact same syntax as the other ecosystems/chains listed and the lint test logs are not very descriptive

To fix the lint issue, just run black or install pre-commit

fubuloubu commented 1 year ago

For the tests, you are right, they won't execute for you specifically because you don't have a Vess to our secrets. If you can run the new test locally (just grab an etherscan key) we can merge it with the lint fix and be on our way

PoCk3T-SPAI commented 1 year ago

Thanks @fubuloubu , done, hope it works!