feat: Add support Etherscan rate limit [APE-774]

ApeWorX / ape-etherscan

Etherscan explorer plugin using EVM-based networks for the Ape Framework

https://www.apeworx.io/

Apache License 2.0

24 stars 26 forks source link

feat: Add support Etherscan rate limit [APE-774] #86

Closed theref closed 1 year ago

theref commented 1 year ago

What I did

fixes: #

How I did it

How to verify it

Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

Overrides https://github.com/ApeWorX/ape-etherscan/pull/77

theref commented 1 year ago

@antazoey are you on the ape discord, couldn't see anyone with the same pic (mine is also different).

antazoey commented 1 year ago

@antazoey are you on the ape discord, couldn't see anyone with the same pic (mine is also different).

im antazoey#5084 on discord, same pic

theref commented 1 year ago

Are you suggesting adding a new class to conftest.py? i guess that inherits from MockEtherscanBackend and just overwrites get_mock_response to return a 429 and then a proper response

antazoey commented 1 year ago

Are you suggesting adding a new class to conftest.py? i guess that inherits from MockEtherscanBackend and just overwrites get_mock_response to return a 429 and then a proper response

i think there is an add_handler() method which allow you to set up a mock.. let me check to see if i can something started

antazoey commented 1 year ago

tests only failing because of secrets / forked repo etc passes locally