feat: add new chains [APE-941]

ApeWorX / ape-etherscan

Etherscan explorer plugin using EVM-based networks for the Ape Framework

https://www.apeworx.io/

Apache License 2.0

22 stars 25 forks source link

Closed bilbeyt closed 1 year ago

bilbeyt commented 1 year ago

Added base and polygon zkevm

fixes: #

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

bilbeyt commented 1 year ago

thanks!

if this works for you, then we are good, consider adding tests and docs. See past PRs that add networks like this.

I didnt try it as i am waiting to merge my new plugins first. I guess without them i cant use these properly.

antazoey commented 1 year ago

I didnt try it as i am waiting to merge my new plugins first. I guess without them i cant use these properly.

OK let us know how it goes.

bilbeyt commented 1 year ago

I didnt try it as i am waiting to merge my new plugins first. I guess without them i cant use these properly.

OK let us know how it goes.

Tried verifications on both polygon zkevm and base goerli using packages locally and they are working fine.

bilbeyt commented 1 year ago

@antazoey can we merge this one as we already transferred ape-base and ape-polygon-zkevm to apeworx organisation? this PR as long as i tried works

antazoey commented 1 year ago

@antazoey can we merge this one as we already transferred ape-base and ape-polygon-zkevm to apeworx organisation? this PR as long as i tried works

Yes, I can do all this right now

antazoey commented 1 year ago

moving to https://github.com/ApeWorX/ape-etherscan/pull/91 because your org prevents us from collaborating.