search

ApeWorX / ape-etherscan

Etherscan explorer plugin using EVM-based networks for the Ape Framework
https://www.apeworx.io/
Apache License 2.0
26 stars 25 forks source link

feat: base and polygon zkEVM network support [APE-1004] #91

Closed antazoey closed 1 year ago

antazoey commented 1 year ago

What I did

I tried pushing to https://github.com/ApeWorX/ape-etherscan/pull/87 but Beamer Bridge does not allow pushing to their branches, so opening a new PR that completes the feature.

Also it is better this way because CI will actually work.

How I did it

How to verify it

Checklist

linear[bot] commented 1 year ago
APE-1004 "feat: base and polygon zkEVM network support" (ApeWorX/ape-etherscan #91)

### What I did I tried pushing to [https://github.com/ApeWorX/ape-etherscan/pull/87](https://github.com/ApeWorX/ape-etherscan/pull/87) but Beamer Bridge does not allow pushing to their branches, so opening a new PR that completes the feature. Also it is better this way because CI will actually work. ### How I did it ### How to verify it ### Checklist * [ ] Passes all linting checks (pre-commit and CI jobs) * [ ] New test cases have been added and are passing * [ ] Documentation has been updated * [ ] PR title follows [Conventional Commit](https://www.conventionalcommits.org/en/v1.0.0/) standard (will be automatically included in the changelog) --- [ApeWorX/ape-etherscan #91](https://github.com/ApeWorX/ape-etherscan/pull/91) by [antazoey](https://github.com/antazoey) on GitHub *via LinearSync*

antazoey commented 1 year ago

approved. can't really approve because had to re-open PR. thanks @bilbeyt for the bulk of the work here.