search

ApeWorX / ape-foundry

Foundry network provider for the Ape Framework
https://www.apeworx.io/
Apache License 2.0
33 stars 13 forks source link

fix: update web3 isConnected() (#19) #20

Closed ghost closed 1 year ago

ghost commented 1 year ago

This is needed as a companion to https://github.com/ApeWorX/ape/pull/1082 since the plugin uses ape's web3 dependency

ghost commented 1 year ago

@unparalleled-js just a heads up, this plugin is affected by the rinkeby removal which is causing tests to fail

ghost commented 1 year ago

@unparalleled-js @NotPeopling2day looks like the test failures here are actually a web3 thing? Saying that it's likely connected to a PoA chain, is there more that needs to be removed with regards to the unsupported networks?

ghost commented 1 year ago

@unparalleled-js @NotPeopling2day looks like the test failures here are actually a web3 thing? Saying that it's likely connected to a PoA chain, is there more that needs to be removed with regards to the unsupported networks?

Bump cc @unparalleled-js @NotPeopling2day

antazoey commented 1 year ago

@unparalleled-js @NotPeopling2day looks like the test failures here are actually a web3 thing? Saying that it's likely connected to a PoA chain, is there more that needs to be removed with regards to the unsupported networks?

I am thinking something like this commit to fix the strange PoA issue: https://github.com/ApeWorX/ape-hardhat/pull/98/commits/cc3337c70c0a24d5b13494bdd2539aca1a19b2ec

But I am not 100% sure what is going on and also experiencing other oddities / failures on that linked branch

ghost commented 1 year ago

Merged in https://github.com/ApeWorX/ape-foundry/pull/22 but still having PoA issues just related around the Goerli impersonation test. Just so we can get the web3 related updates out we're going to merge this now and keep an eye on the PoA thing that's happening