ApeWorX / ape-foundry

Foundry network provider for the Ape Framework
https://www.apeworx.io/
Apache License 2.0
33 stars 13 forks source link

chore: upgrade to 0.6 Ape #29

Closed antazoey closed 1 year ago

antazoey commented 1 year ago

What I did

Needing to do this to test the tracing PR before merging.

fixes: APE-468

How I did it

How to verify it

Checklist

fubuloubu commented 1 year ago

Was fooling around with this branch and got a failure w/ eth_call:

File ~/.pyenv/versions/3.9.14/envs/ape-safe/lib/python3.9/site-packages/ape_foundry/provider.py:440, in FoundryProvider._eth_call(self, arguments)
    438     result = self._make_request("eth_call", arguments)
    439 except Exception as err:
--> 440     raise self.get_virtual_machine_error(err) from err
    442 return HexBytes(result)

VirtualMachineError: invalid type: number, expected a (both 0x-prefixed or not) hex string or byte array containing between (0; 32] bytes
antazoey commented 1 year ago

VirtualMachineError: invalid type: number, expected a (both 0x-prefixed or not) hex string or byte array containing between (0; 32] bytes

yes, a regression from https://github.com/ApeWorX/ape/pull/1242 I should have double checked these provider tests before merging that one, oops.

I am putting in hacky fixes for now for these providers so we can complete the 0.6 release cycle. But then will patch in core and update so that we don't forget and acquire more tech debt.