search

ApeWorX / ape-foundry

Foundry network provider for the Ape Framework
https://www.apeworx.io/
Apache License 2.0
33 stars 13 forks source link

feat: add `set_storage` [APE-1093] #55

Closed fubuloubu closed 1 year ago

fubuloubu commented 1 year ago

What I did

should be compatible with https://github.com/ApeWorX/ape/pull/1484, but not required to merge

linear[bot] commented 1 year ago
APE-1093 "feat: add `set_storage`" (ApeWorX/ape-foundry #55)

### What I did should be compatible with [https://github.com/ApeWorX/ape/pull/1484](https://github.com/ApeWorX/ape/pull/1484) --- [ApeWorX/ape-foundry #55](https://github.com/ApeWorX/ape-foundry/pull/55) by [fubuloubu](https://github.com/fubuloubu) on GitHub *via LinearSync*

fubuloubu commented 1 year ago

NOTE: Also needs implementations for ape-ganache and ape-hardhat

fubuloubu commented 1 year ago

Test failures are a regression of recent evm-trace/ape releases, not this PR

fubuloubu commented 1 year ago

New logic functions correctly, as noted the test failure is due to a regression already on main

antazoey commented 1 year ago

New logic functions correctly, as noted the test failure is due to a regression already on main

hmm, there is a regression on main? I had thought that just the tests needed to be updated. I am looking at this now.

Edit: it is not a regression, a test was getting ahead of itself and is relying on ape core main branch. however surprised fork tests dont run on merge to main, that is what confused me