search

ApeWorX / ape-foundry

Foundry network provider for the Ape Framework
https://www.apeworx.io/
Apache License 2.0
32 stars 13 forks source link

Move `evm_version` from fork config to network config #89

Closed fubuloubu closed 1 month ago

fubuloubu commented 7 months ago

Overview

It would be useful to be able to run anvil in a non-forked configuration using different evm rules, such as right now I am trying to test an EIP from Cancun while Anvil is still using Paris rules by default

Specification

Move it to the top level config like following

foundry:
  evm_version: str = "latest"  # default in anvil

Dependencies

This will definitely conflict with how evm version works with fork networks

could be related to #88

linear[bot] commented 7 months ago

APE-1669 Move `evm_version` from fork config to network config

antazoey commented 1 month ago

Why not have it both at top level and in the forks?

antazoey commented 1 month ago

OK I got the non-breaking change version in the attached PR you can set the evm-version at foundry's config, root, not in the forks. the forks still work, but if they are not set, it will use the global one.

I think this is better because it gives you more control if you need it, but you can also just use the root level evm-version for ease.