Fixes problem about getting correct revert string

ApeWorX / ape-ganache

Ganache network provider plugin for the Ape Framework

https://www.apeworx.io/

Apache License 2.0

4 stars 6 forks source link

Closed bilbeyt closed 1 year ago

bilbeyt commented 1 year ago

Solved the problem of not getting revert string.

Changed the ganache suffix and implemented get_virtual_machine_error to use existing _get_vm_error function.

Just run tests.

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

antazoey commented 1 year ago

Thanks for opening this! I had just fixed this myself on this PR https://github.com/ApeWorX/ape-ganache/pull/13 along with several other fixes.

We will hopefully get a ganache patch out soon!

NotPeopling2day commented 1 year ago

Thank you for help!!