fix: issue where wouldn't show correct not-installed error [APE-918] - Githubissues

ApeWorX / ape-hardhat

Hardhat network provider for the Ape Framework

https://www.apeworx.io/

Apache License 2.0

18 stars 15 forks source link

fix: issue where wouldn't show correct not-installed error [APE-918] #142

Closed antazoey closed 1 year ago

antazoey commented 1 year ago

What I did

fixes: #141 Fixes: APE-910

How I did it

Track if seemingly not installed right
If times out and was not installed right, show custom error

The reason I made it still attempt is because there are situations where it will still work, such as when using subprocess stuff.

How to verify it

Go to a project where Hardhat is not yet installed.
Do `ape console --network etheruem:local:hardhat
Wait for it to fail
Notice the custom error.

Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)