ApeWorX / ape-ledger

Ledger Nano S and X account plugin for the Ape Framework
https://www.apeworx.io/
Apache License 2.0
6 stars 7 forks source link

feat: CLI display before signing transactions and messages #25

Closed antazoey closed 2 years ago

antazoey commented 2 years ago

What I did

fixes: #19

How I did it

Copy ape_accounts core plugin

How to verify it

Sign messages and transactions using your ledger account. Ensure you are prompted on the CLI first and that you are shown the message or transaction you are signing.

Checklist

antazoey commented 2 years ago

As a note, there already is a confirmation prompt on the device, so it seems unnecessary to have it twice. I would suggest simply displaying the message, and then asking the user to confirm on their device

Oh, that works