fix: issue with 'v' byte when signing messages

antazoey commented 2 years ago

What I did

Parity bit calculation is not necessary when signing messages it turns out. That is only for certain types of transactions. Thus, it was causing errors. This PR fixes that as well as fixes the CLI helper methods.

How I did it

Delete parity bit calculation for signing messages

How to verify it

Sign messages using various networks

Checklist

[ ] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[ ] PR title follows Conventional Commit standard (will be automatically included in the changelog)

antazoey commented 2 years ago

[x] Hitting another issue when using that repo... Debugging now, I think I know

issue happened when using multiple ledger accounts in same script. a8de44c fixes it!

fubuloubu commented 2 years ago

Verified this by signing a message and sending a (mainnet fork) transaction w/ Ledger Nano X

ApeWorX / ape-ledger